Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cargo #46

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix cargo #46

merged 1 commit into from
Sep 5, 2024

Conversation

pei-mysten
Copy link
Contributor

@pei-mysten pei-mysten commented Sep 4, 2024

psm is throwing out some issue on sui repo CI pipeline, turns out the version installed by CI is problematic
image

this bump will use psm 0.23 instead.

@pei-mysten pei-mysten requested a review from lxfind September 4, 2024 02:26
@pei-mysten
Copy link
Contributor Author

Hey @lxfind, it seems like this change keeps on failing on gas_pool::tests::test_e2e_gas_station_flow on CI. I tried to run this test locally and can reproduce

running 1 test
test gas_pool::tests::test_e2e_gas_station_flow ... FAILED

failures:

---- gas_pool::tests::test_e2e_gas_station_flow stdout ----
thread 'gas_pool::tests::test_e2e_gas_station_flow' panicked at src/gas_pool/gas_pool_core.rs:133:21:
assertion `left == right` failed
  left: 1000000000
 right: 997024000
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    gas_pool::tests::test_e2e_gas_station_flow

Do you know what might be going wrong here? below is the assertion

assert_eq!(
                        self.get_total_gas_coin_balance(payment).await,
                        new_balance as u64
                    );

left is the gas coin balance returned from client and right new_balance is let new_balance = total_gas_coin_balance as i64 - effects.gas_cost_summary().net_gas_usage();

@lxfind
Copy link
Collaborator

lxfind commented Sep 5, 2024

I will take a look

@pei-mysten pei-mysten merged commit 060f9de into main Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants