Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct checksum for misaligned slices #148

Merged
merged 3 commits into from
May 21, 2024
Merged

fix: correct checksum for misaligned slices #148

merged 3 commits into from
May 21, 2024

Conversation

mlegner
Copy link
Contributor

@mlegner mlegner commented May 17, 2024 •
edited
Loading

Also fix some new linter complaints and pin the SCION reference to the last release with dispatcher (v0.11.0), see also #13.

@mlegner mlegner added bug Something isn't working rust labels May 17, 2024
@mlegner mlegner requested a review from jpcsmith as a code owner May 17, 2024 06:58
@mlegner mlegner marked this pull request as draft May 17, 2024 08:19
@mlegner
fix: correct checksum for misaligned slices
0bc12b2 
Also fix a new lint warning.
@mlegner mlegner marked this pull request as ready for review May 17, 2024 09:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited
Loading

Code Coverage

Package Line Rate Health
crates/scion/src/socket 77% ✔
crates/scion-proto/src/path/metadata 100% ✔
crates/scion/src/pan 78% ✔
crates/scion-proto/src 78% ✔
crates/scion/src/pan/path_strategy 84% ✔
crates/scion/src 80% ✔
crates/scion-proto/src/path/standard 92% ✔
crates/scion-proto/src/packet 80% ✔
crates/scion-proto/src/scmp 71% ➖
crates/scion-proto/src/reliable 95% ✔
crates/scion-proto/src/address 69% ➖
crates/scion-proto/src/packet/headers 85% ✔
crates/scion-proto/src/path 83% ✔
crates/test-utils/src 100% ✔
crates/scion/src/daemon 91% ✔
Summary 79% (1939 / 2468) ✔

jpcsmith
jpcsmith approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@jpcsmith jpcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, looks good. Could we add a test for this bug?

crates/scion-proto/src/packet/checksum.rs Show resolved Hide resolved
@mlegner mlegner enabled auto-merge (rebase) May 21, 2024 12:33
@mlegner mlegner merged commit c813f6f into main May 21, 2024
11 checks passed
@mlegner mlegner deleted the ml/fix-checksum-slice branch May 21, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpcsmith jpcsmith jpcsmith approved these changes

Assignees
No one assigned
Labels
bug Something isn't working rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlegner @jpcsmith