Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for libpulse-simple.pc #138

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Check for libpulse-simple.pc #138

wants to merge 1 commit into from

Conversation

mgorse
Copy link

@mgorse mgorse commented Oct 6, 2017

I needed this change in order to get mimic to build. (I have version 11.0 installed, but pulseaudio-simple.pc has existed since at least version 0.9.12, so this change looks safe to me.)

Needed to pull in libpulse-simple, which contains the pa_simple_* functions
that the pulseaudio driver uses.
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (development@9dfaa6b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #138   +/-   ##
==============================================
  Coverage               ?   40.71%           
==============================================
  Files                  ?       78           
  Lines                  ?     9031           
  Branches               ?     1558           
==============================================
  Hits                   ?     3677           
  Misses                 ?     5354           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dfaa6b...16c0d5e. Read the comment docs.

@mgorse
Copy link
Author

mgorse commented Oct 6, 2017

Sorry; just realized that I pushed this with an invalid email address. Should I submit a new pull request with a correct address?

@zeehio
Copy link
Contributor

zeehio commented Oct 6, 2017

Thanks @mgorse I can reproduce the error. We are in the process of splitting mimic in several components. This fix would need to be applied to the mimic-core component at these two lines:

I will be happy to merge a pull request to that repository if you want to create it (preferably with a valid email address). Otherwise, just tell me here and I will do the commit myself.

Thanks for the report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants