[WIP] fix(button): Icon examples clickable in NVDA #986
Conversation
|
Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-3510 |
github-actions
bot
requested review from
daragh-king-genesys and
jason-evans-genesys
321gillian
force-pushed
the
feature/COMUI-3510
branch
from
65b6723 to
9eb6529
Compare
| <gux-button onclick="notify(event)"> | ||
| <gux-screen-reader-beta> | ||
| This will be read by a screen reader | ||
| </gux-screen-reader-beta> | ||
| <gux-icon icon-name="fa/diamond-regular" decorative></gux-icon | ||
| ></gux-button> |
There was a problem hiding this comment.
I'm not sure whether it makes more sense in this scenario to use provide a way to set the button aria-label rather than introducing another slotted component. We have guxTitle prop but I know we've looked at phasing that out, also don't know if tooltips will always be needed.
It could be something like <gux-button gux-title="This will be read by a screenreader" tooltip-disabled="false"><gux-icon icon-name="fa/diamond-regular" decorative><gux-icon></gux-button>
Suggestions welcome
|
I would be curious to hear more about this issue at collaboration time tomorrow. I need to set up my machine with NVDA to test out this bug. If this is an issue that may affect more than just the |
NVDAIconButtonExample.mp4Adding a video example here to show what happens before we discuss |
COMUI-3510