chore(form-field-text-like): Added role=status for loading indicator #979
Conversation
✅ Closes: COMUI-3408
jason-evans-genesys
changed the title
|
Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-3408-v3 |
✅ Closes: COMUI-3408
| <style | ||
| onload="(function () { | ||
| window.setInterval(() => { | ||
| document.getElementById('dynamic-loading').toggleAttribute('loading'); |
There was a problem hiding this comment.
Do you all think it's not optimal to use setInterval here or does it not matter since it's an example page and I'm trying to demonstrate the loading indicator dynamically showing/hiding so we can see if voiceover picks up on the change?
There was a problem hiding this comment.
Were you able to get voiceover to announce the change when it is dynamically showing/hiding? I wasn't able to get my voiceover to read it out
There was a problem hiding this comment.
I think this will work better if you apply the role="status" to the the gux-radial-loading component within the renderRadialLoading(). Other than that the change LGTM 👍 . Also for voiceover if its role="status" it automatically applies an aria-live of polite which is what is needed here as its not an urgent announcement but a passive one. You have to click on the field for it say Loading on voiceover which is correct I think imo. If you were to use aria-live=assertive it will just say loading regardless of where you are on the page but I dont think we want this as far as I know the assertive should just be used for UI blocking stuff eg loading a page.
✅ Closes: COMUI-3408
✅ Closes: COMUI-3408
✅ Closes: COMUI-3408
jason-evans-genesys
changed the title
✅ Closes: COMUI-3408
I added role="status" around the loading indicator for now so voiceover will pick up when the loading indicator is visible or not.
There is a new ticket to ask UX why we need a loading indicator for all inputs and then also maybe making an API change to slot in the loading indicator element: https://inindca.atlassian.net/browse/COMUI-3539