-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(list): address accessibility console error #920
base: main
Are you sure you want to change the base?
Conversation
Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-3499 |
LGTM. Just needs the snapshots updated |
render(): JSX.Element { | ||
return ( | ||
<Host role="list"> | ||
{this.renderFocusTarget()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an issue with having this focus target element. Both of the following cause accessibility issues
- Having a focusable element with a role of
aria-hidden
is a violation - If you remove the
aria-hidden
, having an element with an invalid role as a descendent of thelist
is a violation.
I have removed this focus target span and instead put a tab index of -1
on the Host.
@@ -18,27 +16,6 @@ export class GuxListItem { | |||
@Prop() | |||
disabled: boolean = false; | |||
|
|||
@Listen('mouseup') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daragh-king-genesys I am tagging you here because you seem to be the one who added this code. Can you remember if this code has any utility that I may be overlooking? I am removing it because it is causing unwanted focus behavior after my changes in the gux-list
file.
Fix a console error that appears after opening a component that contains a
gux-list
then hovering over the first element:I tried adding a test to catch this error but I could not get the accessibility test to fail.