[STREAM-350] - Accept a JWT for video conferencing. Fixed changelog and updated docs. #907
Conversation
…sdk into STREAM-350-1
| @@ -376,8 +376,8 @@ export class GenesysCloudWebrtcSdk extends (EventEmitter as { new(): StrictEvent | |||
| * @returns a promise with an object with the newly created `conversationId` | |||
| */ | |||
| async startVideoConference (roomJid: string, inviteeJid?: string): Promise<{ conversationId: string }> { | |||
| if (this.isGuest) { | |||
| throw createAndEmitSdkError.call(this, SdkErrorTypes.not_supported, 'video conferencing not supported for guests'); | |||
| if (!this._config.jwt && !this._config.accessToken) { | |||
There was a problem hiding this comment.
Why the change here? More curious than anything but to me it appears that isGuest should still suffice here? isGuest is the result of !this.isJwtAuth && !this._config.accessToken and isJwtAuth in turn is !!this._config.jwt. These look to be the same unless I am misunderstanding or missing something.
There was a problem hiding this comment.
Yeah you're right, I didn't bother looking into what this.isGuest was.
There was a problem hiding this comment.
Totally fair! I mean definitely a NIT but I curious more than anything and wanted to make sure I wasn't missing something
| @@ -55,7 +55,8 @@ export interface IMediaChangeEventParticipant { | |||
| } | |||
|
|
|||
| export class VideoSessionHandler extends BaseSessionHandler { | |||
| requestedSessions: { [roomJid: string]: boolean } = {}; | |||
| /** Map of requested room IDs, either jid or conferenceId (JWT) */ | |||
| requestedSessions: { [roomId: string]: boolean } = {}; | |||
There was a problem hiding this comment.
I don't exactly love roomId as a name, but it can now either be a roomJid or a conferenceId. Thinking about it more, maybe we should have more checks below to see if we are using a JWT.
…ferenceId (JWT)." This reverts commit fb68f54.
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
| @@ -60,7 +61,7 @@ describe('Client', () => { | |||
| constructSdk = (config?: ISdkConfig) => { | |||
| /* if we have no config, then use some defaults */ | |||
| if (config === undefined) { | |||
| config = { logger: mockLogger as any, accessToken: 'secure', environment: 'mypurecloud.com', optOutOfTelemetry: true }; | |||
| config = { logger: mockLogger as any, accessToken: 'secure', jwt: 'test-jwt', environment: 'mypurecloud.com', optOutOfTelemetry: true }; | |||
There was a problem hiding this comment.
Codacy has a fix for the issue: Unexpected any. Specify a different type.
| config = { logger: mockLogger as any, accessToken: 'secure', jwt: 'test-jwt', environment: 'mypurecloud.com', optOutOfTelemetry: true }; | |
| config = { logger: mockLogger as unknown, accessToken: 'secure', jwt: 'test-jwt', environment: 'mypurecloud.com', optOutOfTelemetry: true }; |
No description provided.