Fix/arithmetic in functions

src/Value/CSSFunction.php

@@ -33,6 +33,35 @@ public function __construct($sName, $aArguments, $sSeparator = ',', $iLineNo = 0
         parent::__construct($aArguments, $sSeparator, $iLineNo);
     }
 
+    /**
+     * @param ParserState $oParserState
+     * @param bool $bIgnoreCase
+     *
+     * @return string
+     *
+     * @throws SourceException
+     * @throws UnexpectedEOFException
+     * @throws UnexpectedTokenException
+     */
+    public static function parseName(ParserState $oParserState, $bIgnoreCase = false)
+    {
+        return $oParserState->parseIdentifier($bIgnoreCase);
+    }
+
+    /**
+     * @param ParserState $oParserState
+     *
+     * @return array
+     *
+     * @throws SourceException
+     * @throws UnexpectedEOFException
+     * @throws UnexpectedTokenException
+     */
+    public static function parseArgs(ParserState $oParserState)
+    {
+        return Value::parseValue($oParserState, ['=', ' ', ',']);
+    }
+
     /**
      * @param ParserState $oParserState
      * @param bool $bIgnoreCase
@@ -45,9 +74,9 @@ public function __construct($sName, $aArguments, $sSeparator = ',', $iLineNo = 0
      */
     public static function parse(ParserState $oParserState, $bIgnoreCase = false)
     {
-        $mResult = $oParserState->parseIdentifier($bIgnoreCase);
+        $mResult = self::parseName($oParserState, $bIgnoreCase);
         $oParserState->consume('(');
-        $aArguments = Value::parseValue($oParserState, ['=', ' ', ',']);
+        $aArguments = self::parseArgs($oParserState);
         $mResult = new CSSFunction($mResult, $aArguments, ',', $oParserState->currentLine());
         $oParserState->consume(')');
         return $mResult;

src/Value/Value.php

@@ -72,6 +72,9 @@ public static function parseValue(ParserState $oParserState, array $aListDelimit
             }
             $iStartPosition = null;
             while (($iStartPosition = array_search($sDelimiter, $aStack, true)) !== false) {
+                if ($iStartPosition === 0) {
+                    break;
+                }
                 $iLength = 2; //Number of elements to be joined
                 for ($i = $iStartPosition + 2; $i < count($aStack); $i += 2, ++$iLength) {
                     if ($sDelimiter !== $aStack[$i]) {
@@ -156,7 +159,16 @@ public static function parsePrimitiveValue(ParserState $oParserState)
         } elseif ($oParserState->comes("U+")) {
             $oValue = self::parseUnicodeRangeValue($oParserState);
         } else {
-            $oValue = self::parseIdentifierOrFunction($oParserState);
+            $sNextChar = $oParserState->peek(1);
+            try {
+                $oValue = self::parseIdentifierOrFunction($oParserState);
+            } catch (UnexpectedTokenException $e) {
+                if (in_array($sNextChar, ['+', '-', '*', '/'], true)) {
+                    $oValue = $oParserState->consume(1);
+                } else {
+                    throw $e;
+                }
+            }
         }
         $oParserState->consumeWhiteSpace();
         return $oValue;

tests/ParserTest.php

@@ -1240,6 +1240,29 @@ public function lonelyImport()
         self::assertSame($sExpected, $oDoc->render());
     }
 
+    /**
+     * @test
+     */
+    public function functionArithmeticInFile()
+    {
+        $oDoc = self::parsedStructureForFile('function-arithmetic', Settings::create()->withMultibyteSupport(true));
+        $sExpected = 'div {height: max(300,vh + 10);}
+div {height: max(300,vh - 10);}
+div {height: max(300,vh * 10);}
+div {height: max(300,vh / 10);}';
+        self::assertSame($sExpected, $oDoc->render());
+    }
+
+    /**
+     * @test
+     */
+    public function infiniteLoopInFile()
+    {
+        $oDoc = self::parsedStructureForFile('infinite-loop', Settings::create()->withMultibyteSupport(true));
+        $sExpected = 'div {}';
+        self::assertSame($sExpected, $oDoc->render());
+    }
+
     public function escapedSpecialCaseTokens()
     {
         $oDoc = $this->parsedStructureForFile('escaped-tokens');

tests/fixtures/function-arithmetic.css

@@ -0,0 +1,12 @@
+div {
+    height: max(300, vh + 10);
+}
+div {
+    height: max(300, vh - 10);
+}
+div {
+    height: max(300, vh * 10);
+}
+div {
+    height: max(300, vh / 10);
+}

tests/fixtures/infinite-loop.css

@@ -0,0 +1,3 @@
+div {
+    height: ///!;
+}