Add 3 second local lock #835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
commented
Nov 9, 2023
| @@ -86,7 +86,7 @@ impl DeviceLock { | |||
| /// This is determined if the time is less than 2 minutes ago | |||
| pub fn is_locked(&self, id: &str) -> bool { | |||
| let now = now().as_secs(); | |||
| let diff = now - self.time as u64; | |||
| let diff = now.saturating_sub(self.time as u64); | |||
There was a problem hiding this comment.
doubt it but maybe this will fix some edge case bug
benthecarman
force-pushed
the
local-lock
branch
from
0f88989 to
0490e61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a 3 second lock on the local device, this is to hopefully prevent a second instance of mutiny being created on the same device.
Currently what this does is just throw the
AlreadyRunning, alternatively what we could do is just loop and keep checking until the lock is gone, this way if the user quickly closes and quickly re-opens they won't have a chance of running into this error.This interval is short enough where if I refresh the page I am not running into it.