Add audio sink selection dropdown to general settings #164
+278
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donfreiday
commented
Dec 13, 2024
donfreiday
commented
- For now I'm just shelling out to pw-dump and wpctl for sinks
- Might want to consider libwireplumber in the future
- I retained the sink number in the dropdown, since there's no guarantee any other identifier will be unique - i.e. there are two Built-in Audio Stereo, headphones could share the same metadata etc
- Binaries for testing are here https://github.com/donfreiday/muos-frontend/actions/runs/12307667101
| @@ -297,6 +382,7 @@ void init_navigation_groups() { | |||
| apply_theme_list_glyph(&theme, ui_icoHidden, mux_module, "hidden"); | |||
| apply_theme_list_glyph(&theme, ui_icoBGM, mux_module, "bgm"); | |||
| apply_theme_list_glyph(&theme, ui_icoSound, mux_module, "sound"); | |||
| apply_theme_list_glyph(&theme, ui_icoAudioSink, mux_module, "sound"); | |||
There was a problem hiding this comment.
This needs to be "audiosink" like the above user data field
There was a problem hiding this comment.
I like to have differing glyphs.
donfreiday
force-pushed
the
df/feature/audio-sink-select
branch
from
6d5a107 to
73de9cd
Compare
donfreiday
force-pushed
the
df/feature/audio-sink-select
branch
from
73de9cd to
366609c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.