Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: version bump 3.0.0 #54

Merged
merged 1 commit into from
Jun 7, 2024
Merged

chore: version bump 3.0.0 #54

merged 1 commit into from
Jun 7, 2024

Conversation

MusicalNinjaDad
Copy link
Owner

@MusicalNinjaDad MusicalNinjaDad commented Jun 7, 2024

Summary by Sourcery

This pull request updates the project to version 3.0.0, introducing a new feature where fizzbuzzo3.fizzbuzz returns list[str] when passed a list or slice, and continues to return str when passed a single int. Additionally, it includes performance enhancements by allowing a slice to be passed to fizzbuzzo3.fizzbuzz and building rust with --release optimisations. The changelog has been updated to document these changes.

  • New Features:
    • Return list[str] when passed a list or slice, continue to return str when passed a single int.
  • Enhancements:
    • Allow a slice to be passed to fizzbuzzo3.fizzbuzz, providing a 1.5x speed increase over passing a list with the same elements.
    • Build rust with --release optimisations, resulting in a 4-7x speed increase.
  • Documentation:
    • Updated CHANGELOG.md to reflect changes in version 3.0.0.

@MusicalNinjaDad MusicalNinjaDad merged commit 182e5e5 into main Jun 7, 2024
6 checks passed
@MusicalNinjaDad MusicalNinjaDad deleted the py210 branch June 7, 2024 08:57
Copy link

sourcery-ai bot commented Jun 7, 2024

Reviewer's Guide by Sourcery

This pull request updates the version of the FizzBuzz project to 3.0.0. The changes include updating the version number in the CHANGELOG.md file and adding a new feature that returns a list of strings when passed a list or slice, while continuing to return a string when passed a single integer.

File-Level Changes

Files Changes
CHANGELOG.md Updated the version number and added a new feature description in the changelog.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MusicalNinjaDad - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant