Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: MacOS14 CIBW bug (won't move wheel after test) #50

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

MusicalNinjaDad
Copy link
Owner

pathlib.Path.unlink appears to throw a NotADirectoryError on Macos, CIBW only supresses a FileNotFoundError, which is what Pathlib documents (!)

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.

@MusicalNinjaDad MusicalNinjaDad merged commit a0c6073 into main Jun 3, 2024
25 of 35 checks passed
@MusicalNinjaDad MusicalNinjaDad deleted the macos_cibw branch June 3, 2024 16:59
MusicalNinjaDad added a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant