Suppress warning in the one test where we call to_time

[mo-nathan]

Let's see if CI passes and if the code passes for all the other devs. If so, we should just merge this.

[coveralls]

coverage: 93.509%. remained the same
when pulling 193b8ca on njw-to_time-warning-suppression
into 20b1bac on main.

[JoeCohen]

@mo-nathan:
I suggest commenting out the failing assertion in test/jobs/inat_import_job_test.rb:209.
It fails because the test stubbing is screwed up.
I'm working on it at the moment, but don't know if I will finish today.
I don't think we should let it hold up other PRs. It's "just" a test thing.

[nimmolo]

@mo-nathan @JoeCohen
The question here is the global config, though, isn't it?
Rails 7.2 wants us to consider opting in to this config in application.rb.

[JoeCohen]

It passes for me locally.
(with ActiveSupport.to_time_preserves_timezone = true in test_blocked_ips).

[mo-nathan]

I think they are only suggesting setting it if you're using it. It makes no difference for us outside of exactly that one test since we don't use it production code. I see no reason to not just ride with whatever the Rails maintainers think is the default since we really don't care.

[nimmolo]

Still sounds like it should probably be in config/application.rb to prevent a deprecation warning in case we use to_time in some other test in the future.

[mo-nathan]

I think Nimmo and I are aligned on this approach. Haven't heard from @JoeCohen. I'll wait until this evening or tomorrow morning for more feedback. I'll go ahead and merge if I don't hear anything.

[JoeCohen]

Makes sense to me. (Sorry. I thought I had responded earlier.)