Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop assuming lat and lng are in degree, minute, second #2597

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

mo-nathan
Copy link
Member

Addresses #2594.

Old bad behavior:

  1. Go to Create Observation
  2. Clear out any location string
  3. Enter the following as lat/long: 41.63, -70.62 (which is in North Falmouth)
  4. Note that the map updates to somewhere south of Nantucket (which is wrong) [Fixed on branch so the rest doesn't happen]
  5. Note that if you move the pin, it updates the lat/long to something around 41.1, -70.1 (which is south of Nantucket)
  6. If you move the pin to North Falmouth, it updates the lat/long to something close to 41.63/-70.62.
  7. Now select “North Falmouth” from the “New Locality” drop down.
  8. If you now try to edit the latitude to 41.63, it will again jump to somewhere south of Nantucket.
  9. For me, it updates the lat/long to 41.1008/-70.1083.

@coveralls
Copy link
Collaborator

coveralls commented Dec 22, 2024

Coverage Status

coverage: 93.503%. remained the same
when pulling d5c0e58 on njw-lat-lng-js-fix
into 5edcea4 on main.

@mo-nathan mo-nathan requested a review from nimmolo December 22, 2024 14:15
Copy link
Contributor

@nimmolo nimmolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works IRL it certainly looks right as code. Thanks for tackling it!

@mo-nathan mo-nathan merged commit 9367293 into main Dec 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants