Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_level.rb - convert class var to class ivar #1944

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Feb 22, 2024

This @@class_var is not used outside the class, so it seems safe to convert to an ivar.

@nimmolo nimmolo marked this pull request as ready for review July 28, 2024 00:58
@JoeCohen
Copy link
Member

@nimmolo: I hadn't reviewed this because of the push test failure.
I often just re-run the failing test in Github when I see a CI failure because of a system test. But Github isn't giving me that option for this failure.
Is that something you can try?
It would be nice to get your work into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants