Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More oneplus and oplus apps #18

Merged
merged 19 commits into from
Aug 18, 2023
Merged

More oneplus and oplus apps #18

merged 19 commits into from
Aug 18, 2023

Conversation

Application-maker
Copy link
Contributor

No description provided.

@Application-maker Application-maker marked this pull request as ready for review July 23, 2023 19:53
Copy link
Owner

@MuntashirAkon MuntashirAkon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not appear to be well investigated. Please try to investigate a bit and include interesting web links as references. Just because deleting those packages did not affect you does not mean that they wouldn't affect others. There's always a possibility that you've missed something.

oem.json Outdated Show resolved Hide resolved
oem.json Outdated Show resolved Hide resolved
oem.json Outdated Show resolved Hide resolved
@shuvashish76
Copy link
Contributor

shuvashish76 commented Jul 24, 2023

  1. If it's from a single device, try to add all packages in a single PR/commit. (not important)
  2. Basic (whoogle search) investigation & test on your device required.
  3. If (2) doesn't match to your personal investigation or creates confusion (e.g - online investigation suggests it causes bootloop or breaks something but no such issues found in your personal test) then better add them to pending list. Pending list requires only minimal information.
  4. In case you're not comfortable to disable/remove a package for testing because e.g - it might create bootloop or you're simply lazy for basic investigation, then add it to pending list.
  5. Check if package related to any of our suggestions. Add Suggestion ID if necessary.

These are not official repo criteria.***

@MuntashirAkon
Copy link
Owner

Please fix the syntax issues before requesting for a review. Syntaxes are described in the docs.

oem.json Outdated Show resolved Hide resolved
pending.json Show resolved Hide resolved
@MuntashirAkon MuntashirAkon merged commit 73cc2be into MuntashirAkon:master Aug 18, 2023
1 check passed
@Application-maker Application-maker deleted the More-oplus-oneplus branch August 24, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants