Skip to content

Commit

Permalink
fix: try to get tests to work for 3.8
Browse files Browse the repository at this point in the history
  • Loading branch information
MultifokalHirn committed Nov 11, 2023
1 parent d4e195c commit b8f4f16
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 12 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/python-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ permissions:

jobs:
build:
name: Lint & Test for${{ matrix.python-version }}
name: Lint & Test for ${{ matrix.python-version }}
runs-on: ubuntu-latest
strategy:
max-parallel: 1
fail-fast: true
max-parallel: 2
# fail-fast: true
matrix:
python-version: [3.8, 3.11]

Expand Down
16 changes: 9 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,16 @@ install-pdm: venv
$(VENV)/pdm use --venv in-project
.PHONY: install-pdm

bootstrap: clean-venv venv install-pdm dev
bootstrap: clean-venv venv install-pdm dev ## fresh install of venv and dependencies
.PHONY: bootstrap

update: venv
$(VENV)/pdm self update
$(VENV)/pdm lock
.PHONY: update

prod: install-pdm

prod: install-pdm ## install prod dependencies
$(VENV)/pdm sync --fail-fast --prod
.PHONY: dev

dev: install-pdm
dev: install-pdm ## install dev dependencies
$(VENV)/pdm sync --fail-fast --dev
.PHONY: dev

Expand All @@ -36,6 +33,11 @@ app: ## Run the app service
$(VENV)/python -m app
.PHONY: app

update: venv ## update lock file if needed
$(VENV)/pdm self update
$(VENV)/pdm lock
.PHONY: update

## to add additional services, they should follow the same pattern as the example api service:
# api: ## Run the api service
# $(VENV)/python -m api
Expand Down
4 changes: 2 additions & 2 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import logging
from collections.abc import Iterator
from io import StringIO
from typing import Any
from typing import Any, Dict, List

import pytest

Expand All @@ -18,7 +18,7 @@ def __init__(self, *args: Any, **kwargs: Any):
self._entries: list[dict] = []

@property
def entries(self) -> list[dict]:
def entries(self) -> List[Dict]:
# build _entries only once
if not self._entries:
self._entries = [json.loads(line)
Expand Down

0 comments on commit b8f4f16

Please sign in to comment.