Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE Fix strings #4477

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

KatieFrogs
Copy link

While localizing the launcher to Polish, I have encountered some issues in the source strings

  • Typos
  • Casual language, referring to the user as "You"
  • Wrong capitalization
  • Arguments (%1) not being used
  • Not being able to translate URLs (e.g. to change /en-us/ to /pl-pl/)
  • Question marks in checkbox labels

This PR fixes some of the strings I had issues with

@KatieFrogs
Copy link
Author

There is also this mysterious string that just says "Got ", which I assume gets printed into console:
launcher/minecraft/auth/steps/MSAStep.cpp:86

Copy link
Contributor

@phit phit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall really nice cleanup! I just have a couple nitpicks

@@ -286,7 +286,7 @@ QVariant AccountList::data(const QModelIndex &index, int role) const
return tr("Working", "Account status");
}
case AccountState::Errored: {
return tr("Errored", "Account status");
return tr("Error", "Account status");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the past tense here is intentional as the account has errored

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Errored" is not a word that exists in formal language. You have to remember, these words have to be translated into other languages, if words are made up, the translators have to make up their own words as well, which often make even less sense than in the original. The correct form would be "Encountered an error", but there is very little space in the UI to fit such a long string.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errored is very much a real adjective https://en.wiktionary.org/wiki/errored
now you can argue all you want about formal language, but I think that ship has sailed a long time ago in terms of real world usage and at least in German, errored translates perfectly to the adjective fehlerhaft

The correct form would be "Encountered an error"

I too read this https://english.stackexchange.com/questions/3059/is-errored-correct-usage

@@ -124,31 +124,29 @@ bool XboxAuthorizationStep::processSTSError(
case 2148916233:{
emit finished(
AccountTaskState::STATE_FAILED_SOFT,
tr("This Microsoft account does not have an XBox Live profile. Buy the game on %1 first.")
.arg("<a href=\"https://www.minecraft.net/en-us/store/minecraft-java-edition\">minecraft.net</a>")
tr("This Microsoft account does not have an XBox Live profile. Purchasing the game on <a href=\"https://www.minecraft.net/en-us/store/minecraft-java-edition\">minecraft.net</a> is required.")

This comment was marked as outdated.

);
return true;
}
case 2148916235: {
// NOTE: this is the Grulovia error
emit finished(
AccountTaskState::STATE_FAILED_SOFT,
tr("XBox Live is not available in your country. You've been blocked.")
tr("XBox Live is not available in this country. The provided account has been blocked.")

This comment was marked as outdated.

@@ -145,7 +146,7 @@ void Technic::TechnicPackProcessor::run(SettingsObjectPtr globalSettings, const
else
{
// This is the "Vanilla" modpack, excluded by the search code
emit failed(tr("Unable to find a \"version.json\"!"));
emit failed(tr("Unable to find \"version.json\"!"));

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants