Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select field in Android #44

Open
wants to merge 4 commits into
base: pre-release-06-2021
Choose a base branch
from
Open

Conversation

bkoether
Copy link
Collaborator

Hi Steve,

I tried out the app on my Android emulator as well as on a real device and the thing I noticed was that the select drop downs did not work correctly in Android. I also noticed two spots where we still used the old select component and updated it.

Other than that though, I was able to create and edit content.

@bkoether bkoether requested a review from taylor-steve August 30, 2021 19:58
@taylor-steve
Copy link
Collaborator

Hi Ben,

The behavior I was seeing hasn't changed with your update. When I attempt to create or edit content the app immediately throws a component exception and reloads:

TypeError: Object.entries requires that input parameter not be null or undefined

I'm running this on an Android 11 simulator, I haven't tried a real device yet.

This is my first time with Expo and Android, am I missing something obvious? Thanks!

@bkoether
Copy link
Collaborator Author

bkoether commented Sep 2, 2021

Steve, can you let me know a bit more about your environment? PC/Mac, what node version you have installed, what Expo CLI version you are running?

@taylor-steve
Copy link
Collaborator

Hi Ben,

PC/Windows
Node v14.17.6
Expo 4.4.1 (a bit out of date?)
Running on Android Studio 4.1.2, Android 11.0 image

Thanks.

@bkoether
Copy link
Collaborator Author

@steve-taylor-wsu The solution to the Android issue was a bit quicker/easier than anticipated. Please have a look at the code I just pushed and give it a try to see if everything is working on your end now.

@taylor-steve
Copy link
Collaborator

Hi @bkoether

It's getting further now for me which is good. However on the new code if I:

  • Create Content
  • Select "Digital Heritage"
  • Click the "Mukurtu Core" Tab

The app crashes for me, with an error like:

Error: Exception in HostFunction: Malformed calls from JS: field sizes are different.

[[3,3,3,3],[18,2,2,2],[[2233,[2229]],[2235,"RCTView",1,null],[2239,"RCTRawText",1,{"text":"Keywords"}]],9003]

This error is located at:
    in NavigationContainer (at App.js:191)
    in RCTView (at View.js:34)
    in View (at ScrollView.js:1124)
    in RCTScrollView (at ScrollView.js:1250)
    in AndroidSwipeRefreshLayout (at RefreshControl.js:197)
    in RefreshControl (at App.js:176)
    in ScrollView (at ScrollView.js:1286)
    in ScrollView (at App.js:175)
    in RCTView (at View.js:34)
    in View (at App.js:173)
    in Provider (at App.js:172)
    in App (created by ExpoRoot)
    in ExpoRoot (at renderApplication.js:45)
    in RCTView (at View.js:34)
    in View (at AppContainer.js:106)
    in RCTView (at View.js:34)
    in View (at AppContainer.js:132)
    in AppContainer (at renderApplication.js:39)

@bkoether
Copy link
Collaborator Author

@steve-taylor-wsu this is fixed now.

@taylor-steve
Copy link
Collaborator

@bkoether Great thanks. Create Content -> Dictionary Word is exhibiting the same crashing behavior.

@bkoether
Copy link
Collaborator Author

@steve-taylor-wsu Fix pushed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants