Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatpage routes now raise a 404 when they should #754

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

eyeseast
Copy link
Contributor

@eyeseast eyeseast commented Oct 3, 2024

Made flat pages work like other API calls and added tests.

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit e797f0a
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/66fedc762b7556000831f41d
😎 Deploy Preview https://deploy-preview-754.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Oct 3, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.74% 6630 / 30496
🔵 Statements 21.74% 6630 / 30496
🔵 Functions 39.49% 141 / 357
🔵 Branches 56.88% 351 / 617
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/lib/api/flatpages.ts 72.97% 50% 50% 72.97% 10-17, 29-30
src/routes/(pages)/[...path]/+page.svelte 0% 0% 0% 0% 1-14
src/routes/(pages)/[...path]/+page.ts 0% 0% 0% 0% 1
src/routes/(pages)/home/+page.ts 0% 0% 0% 0% 1
Generated in workflow #546 for commit e797f0a by the Vitest Coverage Report Action

Copy link
Member

@allanlasser allanlasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So standard! Love it.

@eyeseast eyeseast merged commit 7c609bd into sveltekit Oct 3, 2024
9 of 10 checks passed
@allanlasser allanlasser linked an issue Oct 3, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise 404 on page route handler
2 participants