Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests Add-On components #521

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Tests Add-On components #521

merged 4 commits into from
Apr 23, 2024

Conversation

allanlasser
Copy link
Member

@allanlasser allanlasser commented Apr 23, 2024

Added test and coverage for these component as part of other work; broke it off as a tiny enhancement PR.

This also introduces snapshot testing to enhance coverage and ensure component stability between builds. If a component no longer matches its snapshot, the test will fail unless the snapshot is updated.

@allanlasser allanlasser added this to the SvelteKit milestone Apr 23, 2024
@allanlasser allanlasser changed the base branch from master to sveltekit April 23, 2024 13:47
Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit fb84f01
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/6627bbc5379d48000719bc9b
😎 Deploy Preview https://deploy-preview-521.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 23, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 40.11% 2690 / 6705
🔵 Statements 40.11% 2690 / 6705
🔵 Functions 24.64% 35 / 142
🔵 Branches 45% 81 / 180
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/lib/components/addons/AddOnListItem.svelte 100% 100% 100% 100%
src/lib/components/addons/AddOnsNavigation.svelte 100% 100% 100% 100%
Generated in workflow #55

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 692a99e
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/6627bddff0f807000874a3a9
😎 Deploy Preview https://deploy-preview-521.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@allanlasser allanlasser changed the title Tests AddOnListItem Tests Add-On components Apr 23, 2024
@allanlasser allanlasser merged commit eda5669 into sveltekit Apr 23, 2024
10 checks passed
@allanlasser allanlasser deleted the sveltekit-addonlistitemtest branch April 24, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants