Project pinning and browser #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for documentcloud-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success84 tests passing in 16 suites. Report generated by 🧪jest coverage report action from f1f87e1 |
eyeseast
reviewed
Feb 8, 2024
allanlasser
force-pushed
the
feature/pinned-projects
branch
2 times, most recently
from
1cf3a80
to
a9558df
Compare
|
The backend now has project pinning support on staging |
|
Embed/share codes are currently broken |
allanlasser
force-pushed
the
feature/pinned-projects
branch
from
91ba458
to
01c0ee3
Compare
@mitchelljkotler From what I can tell, this is a config issue on all of our staged deploys. It looks like the APP_URL env var is missing a trailing @eyeseast I don't have access to the Netlify team, could you confirm this is the case? |
allanlasser
force-pushed
the
feature/pinned-projects
branch
4 times, most recently
from
4a498a4
to
e17149d
Compare
This makes it easier to build flexible layouts without rewriting styles each time. Enhance Flex-ability
Hide public project code Comment out code for public projects
Some more work on debouncing search query Extend delay
Little more optimization of pinned list loading Last bit of optim
- Creates container component for connecting with application state - Creates presentational component with corresponding storybook
allanlasser
force-pushed
the
feature/pinned-projects
branch
from
def750b
to
f1f87e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the application sidebar to present a list of pinned projects, with a button to "Browse" all projects. When the users chooses to "Browse," it opens a drawer with a searchable list of all their projects, as well as all projects shared with them. From this list, projects can be selected to update the search query in the main list view—they can also be pinned to the sidebar for easy access.
This code also supports, in a commented-out state, the ability to browse and pin all public projects. Since the assumption among users is that their projects are currently unviewable, we omit the ability to view public projects until we've given users a chance to make them private.
To support this, a privacy indicator is displayed on all projects in the browser. It also adds a "Private" checkbox to the project creation/editing dialog.