Refactored frontend following best practices #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend/src/App.css.old
Outdated
There was a problem hiding this comment.
This file can be removed if no longer used
There was a problem hiding this comment.
Yes it's no longer used. I temporarily kept it as a source of inspiration for the styling of the availabilities table, to not disregard the others' work, but can be removed from upcoming commits
- also ran 'pnpm add @types/react' to solve typing-related warning - if this works, other scripts will be adapted to TS too
|
Confirmed that using TypeScript solves SonarCloud's typing-related warnings. |
|
AlbertoBaroso
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this Trello card.
The frontend has been restructured both files-wise and appearance-wise following best practices suggested by the web / docs / ChatGPT.
Changes include:
Next steps:
⮱regarding the last point, the Miro board suggests there should be a login page with different auth methods for (non-)members. How will authentication work in that case? Not Auth0?