Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes mentioned in issue: #305 #351

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

ArifShariar
Copy link
Contributor

I have added changes mentioned in the issue #305

  1. Multiple output formats: JSON, SRT and TXT. Users can select the output format from menu
  2. Users can choose the whisper model.

Fixed bug:

  1. If the output directory already exists, it throws an error. Added a check for that so that it does not create a new directory if one already exists.
  2. Comparison using "is" is replaced with "=="

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

Greetings! This is an automated message from GitHub Actions. 🤖
Your pull request has been received and is awaiting for a review by the repository owner or a maintainer. This may take some time, so please be patient.
While you wait, you can continue to work on other issues or pull requests, or explore the project further. Or you can simply relax and enjoy your day.
Thank you for your contribution to this project! You are awesome! ⭐

@Mrinank-Bhowmick
Copy link
Owner

Hey @ArifShariar
Thanks for the changes 🚀
Happy Hacktoberfest ⭐

@Mrinank-Bhowmick Mrinank-Bhowmick merged commit 970ca84 into Mrinank-Bhowmick:main Oct 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants