Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ping_pong.py #317

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Conversation

adixoo
Copy link
Contributor

@adixoo adixoo commented Sep 24, 2023

The previous code had some errors, such as the "os" module not being imported and incorrect variable names, which could lead to program crashes in the middle.

Type of change

  • I added "import os" because the os module was used in the project but not imported.
  • I created variables like "ball_dx" and "ball_dy" that were not declared before but were used in the program, leading to an error.
  • I commented out code that was attempting to play an audio file that was not located in the project directory.
  • Added new comments to make code more readable.
  • Fix the position of the right paddle.
  • Fixed some logic for the ball movements.

The previous code had some errors, such as the "os" module not being imported and incorrect variable names, which could lead to program crashes in the middle.
@github-actions
Copy link
Contributor

Greetings! This is an automated message from GitHub Actions. 🤖
Your pull request has been received and is awaiting for a review by the repository owner or a maintainer. This may take some time, so please be patient.
While you wait, you can continue to work on other issues or pull requests, or explore the project further. Or you can simply relax and enjoy your day.
Thank you for your contribution to this project! You are awesome! ⭐

@Mrinank-Bhowmick
Copy link
Owner

Thanks @adixoo for correcting the codebase 👍

@Mrinank-Bhowmick Mrinank-Bhowmick merged commit 43498ca into Mrinank-Bhowmick:main Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants