Merge pull request #7 from BoogerMan2103/window #36
MrMarbleAnnotations
10 errors and 11 warnings
|
lint:
pkg/asciicast/event_test.go#L34
G601: Implicit memory aliasing in for loop. (gosec)
|
|
lint:
internal/svg/svg.go#L29
type must not be placed after const (desired order: type,const,var,func) (decorder)
|
|
lint:
internal/svg/svg.go#L38
type must not be placed after const (desired order: type,const,var,func) (decorder)
|
|
lint:
cmd/termsvg/main.go#L22
type must not be placed after var (desired order: type,const,var,func) (decorder)
|
|
lint:
cmd/termsvg/main.go#L26
type must not be placed after var (desired order: type,const,var,func) (decorder)
|
|
lint:
internal/svg/svg.go#L68
mnd: Magic number: 1.5, in <argument> detected (gomnd)
|
|
lint:
internal/svg/svg.go#L59
if statements should only be cuddled with assignments (wsl)
|
|
lint:
internal/svg/svg.go#L70
expressions should not be cuddled with blocks (wsl)
|
|
lint:
internal/svg/svg.go#L161
expressions should not be cuddled with blocks (wsl)
|
|
lint:
pkg/asciicast/event_test.go#L74
assignments should only be cuddled with other assignments (wsl)
|
|
test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-go@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, golangci/golangci-lint-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, golangci/golangci-lint-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
lint
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
lint:
pkg/asciicast/asciicast.go#L147
superfluous-else: if block ends with a continue statement, so drop this else and outdent its block (revive)
|
|
lint:
internal/svg/svg.go#L195
superfluous-else: if block ends with a continue statement, so drop this else and outdent its block (revive)
|
|
lint:
internal/svg/svg.go#L42
var-naming: don't use underscores in Go names; func parameter no_window should be noWindow (revive)
|
|
lint:
internal/svg/svg.go#L52
var-naming: don't use underscores in Go names; func parameter no_window should be noWindow (revive)
|
|
lint:
cmd/termsvg/export/export.go#L39
var-naming: don't use underscores in Go names; func parameter no_window should be noWindow (revive)
|
|
lint:
cmd/termsvg/main.go#L34
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|