root: Centralize Detekt configuration

This commit centralizes the Detekt configuration in the root `build.gradle.kts` file and applies it to all subprojects.
MrHadiSatrio · Jul 27, 2024 · c27de21 · c27de21
1 parent 0667149
commit c27de21
Show file tree

Hide file tree

Showing 9 changed files with 26 additions and 101 deletions.
diff --git a/app-android-journal3/build.gradle.kts b/app-android-journal3/build.gradle.kts
@@ -2,7 +2,6 @@ plugins {
     alias(libs.plugins.androidApplication)
     alias(libs.plugins.kotlinAndroid)
     alias(libs.plugins.sentry)
-    alias(libs.plugins.detekt)
     alias(libs.plugins.appVersioning)
 }
 
@@ -84,18 +83,9 @@ dependencies {
     testImplementation(libs.robolectric)
 }
 
-detekt {
-    autoCorrect = true
-    source = files("src/main/kotlin", "src/test/kotlin", "src/androidTest/kotlin")
-}
-
 sentry {
     org.set("mrhadisatrio")
     projectName.set("journal3")
     authToken.set(System.getenv("SENTRY_TOKEN"))
     includeSourceContext.set(true)
 }
-
-dependencies {
-    detektPlugins("io.gitlab.arturbosch.detekt:detekt-formatting:1.23.6")
-}
diff --git a/app-kmm-journal3/build.gradle.kts b/app-kmm-journal3/build.gradle.kts
@@ -2,7 +2,6 @@ plugins {
     alias(libs.plugins.kotlinMultiplatform)
     alias(libs.plugins.androidLibrary)
     alias(libs.plugins.kover)
-    alias(libs.plugins.detekt)
 }
 
 kotlin {
@@ -68,17 +67,3 @@ koverReport {
         }
     }
 }
-
-detekt {
-    autoCorrect = true
-    source = files(
-        "src/commonMain/kotlin",
-        "src/commonTest/kotlin",
-        "src/androidMain/kotlin",
-        "src/androidUnitTest/kotlin"
-    )
-}
-
-dependencies {
-    detektPlugins("io.gitlab.arturbosch.detekt:detekt-formatting:1.23.6")
-}
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -1,3 +1,5 @@
+import io.gitlab.arturbosch.detekt.extensions.DetektExtension
+
 plugins {
     //trick: for the same plugin versions in all sub-modules
     alias(libs.plugins.androidApplication).apply(false)
@@ -17,6 +19,29 @@ allprojects {
     }
 }
 
+subprojects {
+    val libs = rootProject.libs
+
+    apply(plugin = libs.plugins.detekt.get().pluginId)
+    extensions.configure<DetektExtension> {
+        autoCorrect = true
+        source.setFrom(
+            "src/main/kotlin",
+            "src/test/kotlin",
+            "src/commonMain/kotlin",
+            "src/commonTest/kotlin",
+            "src/androidMain/kotlin",
+            "src/androidUnitTest/kotlin",
+            "src/androidTest/kotlin",
+            "src/iosMain/kotlin",
+            "src/iosTest/kotlin"
+        )
+    }
+    dependencies {
+        add("detektPlugins", libs.detekt.formatting)
+    }
+}
+
 sonarqube {
     properties {
         property("sonar.projectKey", "MrHadiSatrio_Journal3")

diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -31,6 +31,7 @@ ktor-mock-engine = { module = "io.ktor:ktor-client-mock", version.ref = "ktor" }
 junit4 = { module = "junit:junit", version = "4.13.2" }
 
 assent = { module = "com.afollestad.assent:core", version = "3.0.2" }
+detekt-formatting = { module = "io.gitlab.arturbosch.detekt:detekt-formatting", version = "1.23.6" }
 flow-binding = { module = "io.github.reactivecircus.flowbinding:flowbinding-android", version = "1.2.0" }
 glide = { module = "com.github.bumptech.glide:glide", version = "4.16.0" }
 kotest-assertions = { module = "io.kotest:kotest-assertions-core", version = "5.8.0" }

diff --git a/lib-kmm-foundation/build.gradle.kts b/lib-kmm-foundation/build.gradle.kts
@@ -2,7 +2,6 @@ plugins {
     alias(libs.plugins.kotlinMultiplatform)
     alias(libs.plugins.androidLibrary)
     alias(libs.plugins.kover)
-    alias(libs.plugins.detekt)
 }
 
 kotlin {
@@ -84,17 +83,3 @@ koverReport {
         }
     }
 }
-
-detekt {
-    autoCorrect = true
-    source = files(
-        "src/commonMain/kotlin",
-        "src/commonTest/kotlin",
-        "src/androidMain/kotlin",
-        "src/androidUnitTest/kotlin"
-    )
-}
-
-dependencies {
-    detektPlugins("io.gitlab.arturbosch.detekt:detekt-formatting:1.23.6")
-}
diff --git a/lib-kmm-geography/build.gradle.kts b/lib-kmm-geography/build.gradle.kts
@@ -2,7 +2,6 @@ plugins {
     alias(libs.plugins.kotlinMultiplatform)
     alias(libs.plugins.androidLibrary)
     alias(libs.plugins.kover)
-    alias(libs.plugins.detekt)
 }
 
 kotlin {
@@ -82,17 +81,3 @@ koverReport {
         }
     }
 }
-
-detekt {
-    autoCorrect = true
-    source = files(
-        "src/commonMain/kotlin",
-        "src/commonTest/kotlin",
-        "src/androidMain/kotlin",
-        "src/androidUnitTest/kotlin"
-    )
-}
-
-dependencies {
-    detektPlugins("io.gitlab.arturbosch.detekt:detekt-formatting:1.23.6")
-}
diff --git a/lib-kmm-io/build.gradle.kts b/lib-kmm-io/build.gradle.kts
@@ -2,7 +2,6 @@ plugins {
     alias(libs.plugins.kotlinMultiplatform)
     alias(libs.plugins.androidLibrary)
     alias(libs.plugins.kover)
-    alias(libs.plugins.detekt)
 }
 
 kotlin {
@@ -76,18 +75,3 @@ koverReport {
         }
     }
 }
-
-detekt {
-    autoCorrect = true
-    source = files(
-        "src/commonMain/kotlin",
-        "src/commonTest/kotlin",
-        "src/androidMain/kotlin",
-        "src/androidUnitTest/kotlin",
-        "src/iosMain/kotlin"
-    )
-}
-
-dependencies {
-    detektPlugins("io.gitlab.arturbosch.detekt:detekt-formatting:1.23.6")
-}
diff --git a/lib-kmm-json/build.gradle.kts b/lib-kmm-json/build.gradle.kts
@@ -2,7 +2,6 @@ plugins {
     alias(libs.plugins.kotlinMultiplatform)
     alias(libs.plugins.androidLibrary)
     alias(libs.plugins.kover)
-    alias(libs.plugins.detekt)
 }
 
 kotlin {
@@ -67,17 +66,3 @@ koverReport {
         }
     }
 }
-
-detekt {
-    autoCorrect = true
-    source = files(
-        "src/commonMain/kotlin",
-        "src/commonTest/kotlin",
-        "src/androidMain/kotlin",
-        "src/androidUnitTest/kotlin"
-    )
-}
-
-dependencies {
-    detektPlugins("io.gitlab.arturbosch.detekt:detekt-formatting:1.23.6")
-}
diff --git a/lib-kmm-paraphrase/build.gradle.kts b/lib-kmm-paraphrase/build.gradle.kts
@@ -2,7 +2,6 @@ plugins {
     alias(libs.plugins.kotlinMultiplatform)
     alias(libs.plugins.androidLibrary)
     alias(libs.plugins.kover)
-    alias(libs.plugins.detekt)
 }
 
 kotlin {
@@ -68,17 +67,3 @@ koverReport {
         }
     }
 }
-
-detekt {
-    autoCorrect = true
-    source = files(
-        "src/commonMain/kotlin",
-        "src/commonTest/kotlin",
-        "src/androidMain/kotlin",
-        "src/androidUnitTest/kotlin"
-    )
-}
-
-dependencies {
-    detektPlugins("io.gitlab.arturbosch.detekt:detekt-formatting:1.23.6")
-}