Fix undefined values (Q and H) and rotation feature #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three fixes: - Fix in constructor undefined Q if FOOTER_HEIGHT props is not set - Fix in onRotate missing Q variable - Uncomment rotation feature (it's working well on my android project)
…ation Fix undefined values + rotation
Mr-Strike
requested changes
Jan 5, 2021
There was a problem hiding this comment.
- Could you please update the PR with a better name for the footer height prop
- Can't add the rotate functionality without testing due to its previous weird behaviour (specifically on iOS)
- Please re-uncomment the rotation feature for the PR to be merged, you can keep the rotation feature on your fork.
vipnetvnn
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three fixes: