Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FUZ-19A - Improve testcase handling in Bugzilla Template #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

FUZ-19A - Improve testcase handling in Bugzilla Template #24

wants to merge 2 commits into from

Conversation

gitstart-app[bot]
Copy link

@gitstart-app gitstart-app bot commented Jan 17, 2025 •
edited
Loading

This PR was created by GitStart to address the requirements from this ticket: FUZ-19.

What is in the PR?

This PR improves how we handle testcase attachments in Bugzilla bug reports. Here's what changed:

  1. Made attachment filenames easier to enter:
    • Can now use templates with file extensions from crash testcases
    • Added support for using filename in bug descriptions with {{testcase_attachment}}
  2. Added automatic mime-type detection:
    • Used 'mime' npm package to detect correct mime-types from file extensions
    • Falls back to:
      • application/octet-stream (for binary files)
      • text/plain (for text files)

CLIENT DEMO VIDEO: https://www.loom.com/share/af46fd8c8bc140509f71ff5f76ca7c52?sid=22c7c360-64bb-4f5e-81db-13c29da909f7

@community-tc-integration Community-TC Integration
Copy link

No Taskcluster jobs started for this pull request

The allowPullRequests configuration for this repository (in .taskcluster.yml on the default branch) does not allow starting tasks for this pull request.

@gitstart-app GitStart App
Copy link
Author

gitstart-app bot commented Jan 17, 2025

This PR is estimated to cost between 25 and 50 credits.
🟡 By merging this PR you agree to this estimate. If you disagree, click here.

1 similar comment
@gitstart-app GitStart App
Copy link
Author

gitstart-app bot commented Jan 20, 2025

This PR is estimated to cost between 25 and 50 credits.
🟡 By merging this PR you agree to this estimate. If you disagree, click here.

@gitstart-app GitStart App
Copy link
Author

gitstart-app bot commented Feb 21, 2025

This PR is estimated to cost between 25 and 50 credits.
🟡 By merging this PR you agree to this estimate. If you disagree, click here.

@gitstart-app gitstart-app bot marked this pull request as ready for review February 21, 2025 18:32
@gitstart-mozilla
Copy link

Contains changes from #18

@jschwartzentruber
Copy link
Collaborator

Fixes #19

@jschwartzentruber
Copy link
Collaborator

The demo looks great. This will need to be rebased, but the diff against fdb57cc looks good to me, besides the comments above.

@gitstart-app GitStart App
Copy link
Author

gitstart-app bot commented Feb 27, 2025

This PR is estimated to cost between 25 and 50 credits.
🟡 By merging this PR you agree to this estimate. If you disagree, click here.

jschwartzentruber
jschwartzentruber requested changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@jschwartzentruber jschwartzentruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still two minor issues.

@gitstart-app gitstart-app bot marked this pull request as draft March 5, 2025 16:59
@gitstart-app GitStart App
Copy link
Author

gitstart-app bot commented Mar 6, 2025

This PR is estimated to cost between 25 and 50 credits.
🟡 By merging this PR you agree to this estimate. If you disagree, click here.

@gitstart-app gitstart-app bot marked this pull request as ready for review March 6, 2025 14:08
@gitstart-app GitStart App
Copy link
Author

gitstart-app bot commented Mar 17, 2025

We have prepared a new estimate of 50 credits for this pull request.
🟡 By merging this PR you agree to this new estimate. If you disagree, click here.

@gitstart-mozilla
Copy link

Continued in MozillaSecurity#1069

@gitstart-mozilla gitstart-mozilla mentioned this pull request Mar 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitstart-mozilla gitstart-mozilla gitstart-mozilla left review comments

@jschwartzentruber jschwartzentruber jschwartzentruber requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitstart-mozilla @jschwartzentruber