-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added _layouts #16
Added _layouts #16
Conversation
Could you describe what you're trying to do? The files you've committed do not look like they're the right ones. |
Please discuss what you want to do in an issue or at least in the pull request description 🙂 @mashsaxena |
Okay. |
The folders are fine. But the files in those folders need discuss. Do we need disqus? Do we need comments at all? In the past comments haven't added value. I personally don't think adding third party content (which invites issues of privacy) is warranted. I don't think about.md and archive.html belong to _layouts either. Please checkout https://jekyllrb.com/docs/layouts/ There is some related info in #2 We may have to move all the theme related files from minima when we are migrating. |
Okay :) |
Hey! Thanks for helping out... might I suggest filling in the Description of the PR template with the things you are modifying/adding and reasoning behind them? Also, I would suggest opening Issues for the same before directly going for PR (except its generic grammar/link fixes). This way we can discuss a bit before you tackle the same if required, and not cause confusion about the intent behind the PR. 😄 |
Hi @mashsaxena, thanks for taking the initiative! However, it's generally a good practice to add all single pages except include:
- _pages So, here's what you need to do:
Feel free to comment here for any doubts. Instructions for merging your fixes with the original commit are given in contributing. |
Needs to be closed or merged with #22 |
What type of Pull Request is this?
Description
Changes proposed in this pull request:
Related Issues and PRs
Fixes #
Mobile & Desktop Screenshots (If any UI changes)