Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make RepositoryManager a composite ReleaseRepository #711

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

skaldarnar
Copy link
Member

@skaldarnar skaldarnar commented Nov 25, 2023

Contains

The public interface of RepositoryManager is basically that of ReleaseRepository. Its purpose is to combine the different sources for game releases and hide where exactly a release is coming from.

Thus, make it implement ReleaseRepository and use the interface in more places instead of the specific class.

Also, drop the ...Adapter suffixes as I'm not sure what they were intended to express anymore. The interface is called ReleaseRepository (with Adapter), and the two classes are implementing that interface.

In addition, this also deletes the unused class JobResult.

How to test

Ensure that the launcher works as before.

Outstanding before merging

Nothing.

The public interface of `RepositoryManager` is basically that of `ReleaseRepository`. Its purpose is to combine the different sources for game releases and hide where exactly a release is coming from.

Thus, make it implement `ReleaseRepository` and use the interface in more places instead of the specific class.
@skaldarnar skaldarnar added Status: Actionable An issue or task that can immediately be worked on Type: Maintenance Maintenance or chores not adding new features or fixing bugs. labels Nov 25, 2023
Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skaldarnar skaldarnar merged commit 1410948 into master Nov 26, 2023
3 checks passed
@skaldarnar skaldarnar deleted the chore/improve-repository-abstraction branch November 26, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Actionable An issue or task that can immediately be worked on Type: Maintenance Maintenance or chores not adding new features or fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants