Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: small adjustments in settings view #537

Merged
merged 3 commits into from
Mar 28, 2020
Merged

fix: small adjustments in settings view #537

merged 3 commits into from
Mar 28, 2020

Conversation

jdrueckert
Copy link
Member

  • fix the launcher user data directory label
  • remove the option to change the game data directory as per Refine directory structure and management #469 currently we don't move the contents to the new directory and re-introducing this is only planned for post v4.0.0

@jdrueckert
fix: launcher user data directory label
d8073f5
@jdrueckert
fix: remove option to change game data directory
f84b876 
- as per #469 we currently don't move the contents of the game data directory when it's changed
- until we do it's better to disable the option to change it entirely
- this will potentially re-introduced post v4.0.0
@jdrueckert jdrueckert added Type: Bug Bug reports for launcher releases (reproducible from master) Status: Actionable An issue or task that can immediately be worked on Topic: Configuration Related to configuration design, settings and storage labels Mar 28, 2020
@jdrueckert jdrueckert added this to the v4.0.0 milestone Mar 28, 2020
@jdrueckert jdrueckert self-assigned this Mar 28, 2020
@jdrueckert jdrueckert added Topic: UI Related to user interface (UI) or design. and removed Topic: Configuration Related to configuration design, settings and storage labels Mar 28, 2020
skaldarnar
skaldarnar approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the label "message_error_gameDataDirectory" used somewhere else, or can it be removed?

@skaldarnar skaldarnar merged commit 17a3e09 into master Mar 28, 2020
@skaldarnar skaldarnar deleted the topic/settings-view branch March 28, 2020 15:49
@skaldarnar skaldarnar mentioned this pull request Mar 28, 2020
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skaldarnar skaldarnar skaldarnar approved these changes

@praj-foss praj-foss Awaiting requested review from praj-foss

Assignees

@jdrueckert jdrueckert

Labels
Status: Actionable An issue or task that can immediately be worked on Topic: UI Related to user interface (UI) or design. Type: Bug Bug reports for launcher releases (reproducible from master)
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jdrueckert @skaldarnar