Skip to content

Commit

Permalink
chore: fix check run annotations, use new codemetrics version (#607)
Browse files Browse the repository at this point in the history
* chore: fix check run annotations, use new codemetrics version

* fix: update to codemetrics 1.5.1

* chore: remove empty lines
  • Loading branch information
jdrueckert authored Nov 15, 2020
1 parent 87b6df1 commit 9eff7c0
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ dependencies {
}

// Config for our code analytics from: https://github.com/MovingBlocks/TeraConfig
codeMetrics group: 'org.terasology.config', name: 'codemetrics', version: '1.4.0', ext: 'zip'
codeMetrics group: 'org.terasology.config', name: 'codemetrics', version: '1.5.1', ext: 'zip'
}

configurations.matching({ it =~ ~/test(Runtime|Compile|Implementation)Classpath/ }).all {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,10 @@ public void initialize() {

/**
* Initialize the combo boxes for version selection by setting up bindings and properties.
*
* <p>
* This happens after the FXML elements have been initialized, but before managers and other dependencies have been
* "injected" to this controller.
*
* <p>
* The combo boxes are configured with custom {@link javafx.scene.control.ListCell} implementations to display
* human-readable representations of game profiles and game releases. We also bind which game releases are visible
* to the selected profile, and derive the currently selected release from the combo box's selection model.
Expand Down Expand Up @@ -219,10 +219,10 @@ private void initComboBoxes() {

/**
* Initialize buttons by setting up their bindings to observable values or properties.
*
* <p>
* This happens after the FXML elements have been initialized, but before managers and other dependencies have been
* "injected" to this controller.
*
* <p>
* The buttons "Play", "Download", and "Cancel Download" share the space in the UI. We make sure that only one of
* them is shown at the same time by deriving their visibility from the current {@link GameAction}. As JavaFX will
* still occupy space for non-visible nodes, we also bind the {@code managedProperty} to the visibility (nodes that
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

//TODO: should this be called `SettingsController` and also carry out some UI handling, e.g., displaying error messages
// to the user?
public class Settings {
public final class Settings {
public static final String DEFAULT_FILE_NAME = "TerasologyLauncherSettings.properties";

private static final Logger logger = LoggerFactory.getLogger(Settings.class);
Expand Down

0 comments on commit 9eff7c0

Please sign in to comment.