Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compilejava should create versioninfo file #5259

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Conversation

soloturn
Copy link
Contributor

@soloturn soloturn commented Jun 30, 2024

versionInfo.properties was not created, depend on it when doing

gradle --console=plain clean extractConfig extractNatives distForLauncher testDist

not sure yet about Credits.md:

❯ find . -name Credits.md
./docs-pre-merge/Credits.md

which is not "docs" as written in build.gradle.kts

another question i'd have, what this TODO means?

//TODO: Remove this when gestalt can handle ProtectionDomain without classes (Resources)

@skaldarnar
Copy link
Member

Previously (https://github.com/MovingBlocks/Terasology/blob/5eceac78293f8edbc84c1a2e6f60a648f8295800/engine/build.gradle) the dependency chain was

tasks.named("compileJava") {
dependsOn(tasks.named("copyResourcesToClasses"))
}

tasks.register("copyResourcesToClasses", Copy) {
from processResources
into sourceSets.main.output.classesDirs.first()

tasks.named("processResources", Copy) {
from(createVersionInfoFile) {
into("org/terasology/engine/version/")
}

so we jumped through a bunch of hoopes to eventually included the version info file whenever we to compileJava. The chain still looks to be in place, but somehow the file is not found/copied/whatever?

I'll try to test this out later, currently just looking at the changes on Github...

@soloturn
Copy link
Contributor Author

soloturn commented Jul 7, 2024

so we jumped through a bunch of hoopes to eventually included the version info file whenever we to compileJava. The chain still looks to be in place, but somehow the file is not found/copied/whatever?

yes, this looked unnecessary complicated, and, not sure why, but did not work any more. so i thought let the dependency be direct.

@BenjaminAmos BenjaminAmos merged commit 855b2be into develop Jul 13, 2024
13 of 15 checks passed
@BenjaminAmos BenjaminAmos deleted the versioninfo branch July 13, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants