Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further support for qq adapter #117

Closed
wants to merge 17 commits into from

Conversation

Dreamail
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feat/adapter-qq@d122437). Click here to learn what that means.

❗ Current head dd7527d differs from pull request most recent head 9aa1c71. Consider uploading reports for the commit 9aa1c71 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                 @@
##             feat/adapter-qq     #117   +/-   ##
==================================================
  Coverage                   ?   94.59%           
==================================================
  Files                      ?       24           
  Lines                      ?     1647           
  Branches                   ?        0           
==================================================
  Hits                       ?     1558           
  Misses                     ?       89           
  Partials                   ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felinae98
Copy link
Collaborator

因为 #119 引入了专门的 target,所以请 rebase 一下 main,使用新的 target

@Dreamail
Copy link
Contributor Author

OK

@Dreamail
Copy link
Contributor Author

rebase 完了,但是test不懂该怎么写(主要是bot specifier的,nonebug没用过得下次有空我再看看了

@Dreamail
Copy link
Contributor Author

Dreamail commented Nov 25, 2023

nonebot/adapter-qq#86

上游adapter有点问题

@Dreamail Dreamail force-pushed the feat/adapter-qq branch 2 times, most recently from fa85307 to 56d70f6 Compare November 25, 2023 05:49
@Dreamail
Copy link
Contributor Author

test修好了

@Dreamail
Copy link
Contributor Author

Dreamail commented Nov 25, 2023

#122
得先merge一下这个

#113

@felinae98
Copy link
Collaborator

解决一下和上游的 conflict?

@Dreamail
Copy link
Contributor Author

Dreamail commented Nov 27, 2023

解决一下和上游的 conflict?

要不我直接pr到main好了,然后再处理conflict
(feat/adapter-qq时不时又有提交搞得有点乱

@Dreamail Dreamail changed the title fix some bug in qq adapter further support for qq adapter Nov 28, 2023
@felinae98 felinae98 deleted the branch MountainDash:feat/adapter-qq December 8, 2023 15:33
@felinae98 felinae98 closed this Dec 8, 2023
@felinae98
Copy link
Collaborator

可以进一步适配了

@Dreamail
Copy link
Contributor Author

Dreamail commented Dec 8, 2023

那我提pr到main?

@felinae98
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants