为 auto select bot 加入更多日志信息 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for send-anything-anywhere ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
- Coverage 95.30% 95.26% -0.04%
==========================================
Files 23 23
Lines 1511 1521 +10
==========================================
+ Hits 1440 1449 +9
- Misses 71 72 +1
☔ View full report in Codecov by Sentry. |
he0119
reviewed
Oct 19, 2023
| @@ -26,11 +27,13 @@ def _register_hook(): | |||
|
|
|||
| @driver.on_bot_connect | |||
| async def _(bot: Bot): | |||
| logger.info(f"connect bot {bot}") | |||
There was a problem hiding this comment.
应该是 refresh bot 吧，既然下面是 pop bot 的话。
There was a problem hiding this comment.
要不下面 disconnect bot 好了
There was a problem hiding this comment.
会不会没啥意义？不如写多点，比如 refreshing bot targets cache 之类的。
felinae98
force-pushed
the
feat/debug-info
branch
from
ce37844 to
2c328da
Compare
he0119
reviewed
Oct 19, 2023
felinae98
force-pushed
the
feat/debug-info
branch
from
2c328da to
8e1e5ed
Compare
he0119
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.