Allow custom Abstraction implementation. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of 2 PRs, this one allows custom MixinExtras implementation classes.
Additionally, it can be used by compatibility layers like KiltMC to set an already existing backend:
System.setProperty("mixinconstraints.abstraction", "com.moulberry.mixinconstraints.FabricAbstractionsImpl")(KitlMC is a mod to load forge mods on Fabric, so it would make MixinConstraints not pick the forge backend on Fabric)
I also had to deprecate
getLoader()as now custom mod loaders can be used, this APIs make a lot less sense.I added
getLoaderName()API as a replacement for thegetLoader()API.Close: #8