-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom API for loading in a custom environment. #8
Comments
Im not Moulberry so I can't talk on his behalf but a way I can see this that would work best is using a service loader or some property to override the abstractions class to get from the class loader |
I was thinking about using a property for that, as it's much simpler to do than a service loader, but both are 100% fine. I was also thinking of contributing on how some internals works to make the loading the extension work in the same way MixinExtras/MixinSquared work, so using a custom MixinPlugin would not necessary if the bootstrap init method was called. If I my contributions are wanted, I'll do separate PRs for both changes. |
Property seems fine. It could potentially cause issues if a new constraint annotation needs to be added which the custom environment doesn't support. I suppose in that case it can just default to always passing. PR is welcome. |
Don't worry about adding new stuff, it's up to the consumer of the Abstraction API to adapt to new updates. |
I made both my PRs: They should be able to be merged in any order. |
I'm making my own mod loader, and wanted to incorporate MixinConstraints into my ModLoader by default.
Currently it only allows for FORGE/NEOFORGE/FABRIC, and I would like to use it on my custom made ModLoader.
I can also contribute code if needed. (I already designed one possible way to implement this in my mind)
The text was updated successfully, but these errors were encountered: