Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OptiFine Parity] PBR Support for Animated Entity Textures #97

Open
1 task done
Thanos1716 opened this issue Aug 16, 2024 · 0 comments
Open
1 task done

[OptiFine Parity] PBR Support for Animated Entity Textures #97

Thanos1716 opened this issue Aug 16, 2024 · 0 comments
Assignees
Labels
type: bug Something isn't working

Comments

@Thanos1716
Copy link

Thanos1716 commented Aug 16, 2024

OptiFine applies the PBR from the base texture (e.g. iron_golem_n.png) to animated entity textures as well. With MoreMcmeta however, in order to animate the entity texture it seems to completely disable PBR for the entity.

This becomes apparent in the Patrix resource packs, specifically for the Iron Golem and Warden. In the example below, I have made the iron golem texture completely white as to make the normal and specular maps clearer.

This issue also affects Animatica FoundationGames/Animatica#57

Here is a minimum reproducible example of the issue:
Patrix_1.21_32x_basic_MRE_iron_golem.zip

Steps to reproduce the behavior:

  1. Install MoreMcmeta and Iris
  2. Install any shader pack that supports LabPBR
  3. Install Patrix (or above MRE)
  4. Look at an Iron Golem

Below is a comparison using Complementary Shaders on all default settings apart from enabling labPBR in the shader settings:

OptiFine:

2024-08-16_15 00 25

MoreMcmeta & Iris (& EMF & ETF but occurs without these)

2024-08-16_15 08 59

Which Minecraft versions does this bug affect?
Checked in 1.21.1, likely affects all versions.

Mod loader

  • Fabric
    Forge likely affected with Oculus as well.

Resource pack
The original resource pack: https://modrinth.com/resourcepack/patrix-32x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants