Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tools): add unlock democracy funds script #41

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

links234
Copy link
Contributor

@links234 links234 commented Feb 29, 2024

In this PR I add script to be ran by foundation in order to unlock
democracy funds. Tested locally with chopsticks.

Copy link
Contributor

@RomarQ RomarQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting in files not related to the migration scripts should be reverted and the scripts moved to tools folder (the lazy migrations are not hotfixes). The lazy migration for local assets removal can be removed in favor of #42

@links234 links234 force-pushed the links234/rt2800-rt2900-lazy-migration-scripts branch from 950082d to 9a4d47f Compare April 2, 2024 09:16
@links234 links234 changed the title Add unlock democracy funds script (RT2800) and remove local assets script (RT2900) chore(tools): add unlock democracy funds script Apr 2, 2024
@links234 links234 requested a review from RomarQ April 2, 2024 09:18
@links234
Copy link
Contributor Author

links234 commented Apr 2, 2024

the scripts moved to tools folder (the lazy migrations are not hotfixes)

That's right but I think tools is a stretch too. Ideally there should be a lazy migration folder with a naming to capture the order in which they were applied.

@RomarQ
Copy link
Contributor

RomarQ commented Apr 2, 2024

the scripts moved to tools folder (the lazy migrations are not hotfixes)

That's right but I think tools is a stretch too. Ideally there should be a lazy migration folder with a naming to capture the order in which they were applied.

I agree with that, I will be running the migration against moonbase and then move this to other folder in another PR.

@RomarQ RomarQ merged commit 423a258 into main Apr 2, 2024
1 check failed
@RomarQ RomarQ deleted the links234/rt2800-rt2900-lazy-migration-scripts branch April 2, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants