forked from matter-labs/era-test-node
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Test Scaffolding #7
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
package.json
Why ✋
build
script, whilst running yarn build will build for all packages.yarn dev:start
from any location in repoEvidence 📷
❯ yarn dev:start Node is running and accepting requests! Node launched successfully, PID: 462981 ✅
Single command to build all packages:
Notes 📝
Note
Workspaces are such a timesaver in the long run and are relatively cheap to implement at the beginning of a repo like this. We should definitely consider either
yarn
orpnpm
workspaces feature to manage dependencies across multiplepackage.json
. In trying a few things for this PR I've already found it helpful being able to juggle the multiple pkg vers, like@matterlabs/hardhat-zksync-solc
Note
Ideally we want to make this an ESM project, for future proofing and access to the latest libraries - however hardhat sadly is still using
ts-node
. I've put a comment to suggest they switch to tsx but we may be waiting a while for that.Important
Please disregard the stupendous amounts of commits in this PR. Work was done to try to get coverage to work with the GihubActions workers, but it seems like there's no getting around this needs to be a
self-hosted
only workflow, due to the process being too heavy.