Zero-segment Workaround #46
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
Remove call to
add_zero_zegment()in Mod builtinDescription
This PR works around an issue related to
run_validity_checks()where themul_modbuiltin has an additional memory segment which causes the index verification to fail here.This isn't meant to be a viable fix. I suspect that a proper fix would be to account for the additional segments in the index checks in
run_validatity_checks()or similar.However, the
zero_segmentfunctionality (introduced here) is unclear to me, so this is meant as a temporary workaround to help us progress in SNOS.If anyone is able to explain the
zero_segmentfunctionality and how it relates torun_validity_checks(), I'll be happy to work on a better fix.Checklist