forked from lambdaclass/cairo-vm
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SECP hints required for k1 and r1 curves #41
Open
whichqua
wants to merge
32
commits into
main
Choose a base branch
from
gm/secp-hints-rc5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark Results for unmodified programs 🚀
|
9 tasks
whichqua
force-pushed
the
gm/secp-hints-rc5
branch
from
August 7, 2024 14:19
85a15c8
to
3c5cec8
Compare
whichqua
force-pushed
the
gm/secp-hints-rc5
branch
from
August 7, 2024 15:20
51e0f3d
to
d68a3a2
Compare
lock cairo1 versions
whichqua
force-pushed
the
gm/secp-hints-rc5
branch
2 times, most recently
from
August 12, 2024 14:35
35a9fc7
to
2c12c1f
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement SECP hints required for k1 and r1 curves
Problem: Secp hints are not defined
Solution: Implement them all
Description
This PR implements secp256(k1|r1) hint processing functions and their unit tests in the Cairo VM
Checklist