fix: Source freshness errors with optional filter arg #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using optional freshness argument
filter
the hookcheck_source_has_freshness.py
returns the following error:AttributeError: 'str' object has no attribute 'keys'
It happens because the hook is expecting dictionaries (warn_after and error_after), but filter is a string.
A simple fix is to pop the key if it exists before checking for required keys as I did in the PR.
Obs: I had to change github flake8 pre-commit hook from gitlab to github because I don't have a gitlab acc, feel free to change back to gitlab if you guys think it's necessary.
Testing
pytest tests/unit/test_check_source_has_freshness.py