Resolve #217 - Update runner labels when needed #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the role is run against a runner that is already registered, the role will now update the runner labels if they have changed. The tests have been updated to reflect this.
|
Am I correct that the CI is failing because I don't have permissions to deploy to test? |
Hi @daltonv yes you are right. I will adjust the actions workflow to not to confuse contributors. Will check your PR soon. Thanks! |
MonolithProjects
merged commit fe97ec3
into
MonolithProjects:develop
5 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the role is run against a runner that is
already registered, the role will now update the
runner labels if they have changed.
The tests have been updated to reflect this.
Type of change
How Has This Been Tested?
I have tested this against a physical runner I own as well as updating the molecule tests to reflect this change.