Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow binding with user-provided credentials #55

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

feat: Allow binding with user-provided credentials #55

wants to merge 34 commits into from

Conversation

TuringTux
Copy link
Contributor

@TuringTux TuringTux commented Jun 16, 2024 •
edited
Loading

Closes #57: If you don't want to use an LDAP service user, you can now bind to the LDAP server with the user-specified credentials.

Changes

  1. Update README, explain how to use user-provided credentials for binding
  2. When user-provided credentials are to be used, bind to the server with those
  3. Generally re-format README, make relevant snippets directly visible
  4. Extract a lot of the logic in connector.py to dedicated functions

@TuringTux TuringTux mentioned this pull request Oct 20, 2024
Open
@TuringTux
🐛 Actually return the server instance
6df9163
@TuringTux
♻️ Add BIND_WITH_USER_PROVIDED_CREDENTIALS constant
4ec6eaa
@TuringTux
✨ Use dedicated config constant
44ab49d
@TuringTux
🐛 Pass user-provided password
ad6b526
@TuringTux
♻️ Extract finding users to function
8720357
@TuringTux
♻️ Immediately return only a single user
4effa45
@TuringTux
♻️ Extract _ensure_has_required_attributes
7ecca17
@TuringTux
♻️ Use f-strings for arguably a bit more concise notation
15fd5f0
@TuringTux
♻️ Use if-expression to avoid mutable variables
f232ca7
@TuringTux
🐛 Keep raw attributes in method
c2f793d
@TuringTux
♻️ Move getting user details to after bind
191a51b
@TuringTux
♻️ Combine verification for attributes and extraction into one method
fe0087f
@TuringTux
📝 Adjust documentation to new spec
d113033
@TuringTux
♻️ Make profile attributes a constant
5f417f8
@TuringTux
📝 Remove irrelevant UI mention
bdcab87
@TuringTux
✏️ Remove trailing whitespace
714ae9c
@TuringTux
🐛 Remove incorrect c.
1d21e25
@TuringTux
🎨 Reformat file with black
b79e334
@TuringTux
📝 Improve docstrings, reformat
484527a
@TuringTux
📝 Add missing docstring
9b43a72
@TuringTux TuringTux changed the title feat: Allow binding with user-specified credentials feat: Allow binding with user-provided credentials Oct 20, 2024
@TuringTux TuringTux marked this pull request as ready for review October 20, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use user-provided credentials to bind to LDAP server
1 participant
@TuringTux