Skip to content

Commit

Permalink
Bump Go to 1.21, set and use KAFKA_BOOTSTRAP_SERVERS correctly in mak…
Browse files Browse the repository at this point in the history
…efile to use internal advertised listeners when running testacc under docker
  • Loading branch information
Anonymous committed Feb 19, 2024
1 parent df230b8 commit be82e9b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.16
FROM golang:1.21

WORKDIR /go/src/github.com/Mongey/terraform-provider-kafka/

Expand Down
3 changes: 2 additions & 1 deletion GNUmakefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
GOFMT_FILES?=$$(find . -name '*.go' |grep -v vendor)
KAFKA_BOOTSTRAP_SERVERS ?= localhost:9092
default: build

build:
Expand All @@ -9,7 +10,7 @@ test:

testacc:
GODEBUG=x509ignoreCN=0 \
KAFKA_BOOTSTRAP_SERVERS=localhost:9092 \
KAFKA_BOOTSTRAP_SERVERS=$(KAFKA_BOOTSTRAP_SERVERS) \
KAFKA_CA_CERT=../secrets/ca.crt \
KAFKA_CLIENT_CERT=../secrets/client.pem \
KAFKA_CLIENT_KEY=../secrets/client.key \
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.testacc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ services:
testacc:
build: .
environment:
KAFKA_BOOTSTRAP_SERVER: kafka1:9090,kafka2:9090,kafka3:9090
KAFKA_BOOTSTRAP_SERVERS: kafka1:9090,kafka2:9090,kafka3:9090
entrypoint:
- make
- testacc
Expand Down

0 comments on commit be82e9b

Please sign in to comment.