Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AIMNET2 harness #443

Merged
merged 12 commits into from
May 2, 2024
Merged

Add AIMNET2 harness #443

merged 12 commits into from
May 2, 2024

Conversation

jthorton
Copy link
Contributor

@jthorton jthorton commented Mar 14, 2024

Description

This PR adds an interface to the new AIMNET2 models via a small utility package pyaimnet2 which allows access to the models via python.

Changelog description

Status

  • Code base linted
  • Ready to go

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Merging #443 (e0a53a0) into master (f5f6da3) will decrease coverage by 2.65%.
The diff coverage is 94.80%.

Additional details and impacted files

@loriab
Copy link
Collaborator

loriab commented Apr 8, 2024

Perhaps go ahead and rebase this to fix the conflicts. CI should pass now.

As an AI model, is this training-to-emulate the 3c, etc. methods? I'm checking that I understand why the dftd3/d4/gcp programs aren't dependencies.

# Conflicts:
#	.github/workflows/CI.yml
#	qcengine/programs/base.py
#	qcengine/programs/tests/test_programs.py
#	qcengine/testing.py
#	qcengine/tests/test_harness_canonical.py
@jthorton
Copy link
Contributor Author

jthorton commented Apr 9, 2024

Thanks @loriab this should be ready to go now!

As an AI model, is this training-to-emulate the 3c, etc. methods? I'm checking that I understand why the dftd3/d4/gcp programs aren't dependencies.

Yes I think the b973c model is trained to the whole composite method energies whereas the wb97m-d3 model has a pytorch implementation of D3 which is part of the model.

qcengine/tests/test_harness_canonical.py Outdated Show resolved Hide resolved
qcengine/programs/aimnet2.py Outdated Show resolved Hide resolved
qcengine/programs/aimnet2.py Outdated Show resolved Hide resolved
qcengine/programs/aimnet2.py Outdated Show resolved Hide resolved
qcengine/programs/tests/test_programs.py Show resolved Hide resolved
@jthorton
Copy link
Contributor Author

@loriab this should be good to go now, let me know if you spot anything else!

Copy link
Collaborator

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

CI is fine in a fresh PR, and the failing lane shouldn't be hitting this content, so merging.

@loriab loriab merged commit 6b25916 into MolSSI:master May 2, 2024
19 of 20 checks passed
@jthorton
Copy link
Contributor Author

jthorton commented May 2, 2024

Thanks @loriab !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants