Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a harness for MACE-OFF23 and local MACE models #441

Merged
merged 10 commits into from
Apr 8, 2024

Conversation

jthorton
Copy link
Contributor

@jthorton jthorton commented Jan 5, 2024

Description

This PR adds a new harness for ML models based on the MACE architecture, supporting local models and three general organic force field published models (MACE-OFF23) which can be found here. More information about the performance can be found here.

Changelog description

Add new harness for MACE ML models supporting local and the general MACE-OFF23 models.

Status

  • Code base linted
  • Ready to go

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Merging #441 (77dc7b5) into master (7cad296) will decrease coverage by 1.69%.
The diff coverage is 96.59%.

Additional details and impacted files

Copy link
Collaborator

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm. Is there a test that can be added that checks a numerical result? I think the CI failures are unrelated and minor, but I can't fix them until next week.

@jthorton
Copy link
Contributor Author

Hi, @loriab just checking if anything else needs to be done to get this finished up :)

@loriab loriab merged commit f5f6da3 into MolSSI:master Apr 8, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants