Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pydantic v1 API even with v2 #412

Closed
wants to merge 1 commit into from

Conversation

Lnaden
Copy link
Collaborator

@Lnaden Lnaden commented Jul 31, 2023

Description

The correct version of #411. I had originally had branched from a point way in the past.

Supersedes #411

Changelog description

Status

  • Code base linted
  • Ready to go

The correct version of #736. I had originally had branched from a point way in the past.
@Lnaden Lnaden mentioned this pull request Jul 31, 2023
2 tasks
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #412 (2542bdf) into master (1887e71) will decrease coverage by 24.19%.
The diff coverage is 83.33%.

Additional details and impacted files

@loriab
Copy link
Collaborator

loriab commented Aug 1, 2023

I bet MolSSI/QCElemental#305 has to do with the QChem QCEngineRecords trouble. MolSSI/QCElemental#315 may be on track to solution or just related.

@loriab loriab closed this in #414 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants